This repository has been archived by the owner on Sep 20, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief description
Fix access to width of geometry in
ScrollMessageBox
.Description
The
ScrollMessageBox
tried to access width of desktop by accessingwidth
attribute but it is a method so comparison failed.Also renamed variable
max_len
tomessage_len
.Additional info
We should maybe rewrite the whole dialog as the logic of size definition is not readable much. The dialog also contains "Copy to clipboard" button which is on right side next to OK and Cancel which is not very intuitive. Dialog does not have enabled close.
Testing notes:
Resolves #4243 (comment)